wit_tactic top type is tacvalue#21680
Open
SkySkimmer wants to merge 2 commits intorocq-prover:masterfrom
Open
Conversation
SkySkimmer
added
kind: cleanup
coqbot-app
bot
removed
the
request: full CI
ppedrot
reviewed
Feb 27, 2026
plugins/ltac/tacexpr.mli
Outdated
| | GlbAppl of (Names.KerName.t * Geninterp.Val.t list) list | ||
| (** For calls to global constants, some may alias other. *) | ||
|
|
||
| type tacvalue = |
Member
There was a problem hiding this comment.
Maybe this is the reason I never implemented this change, but I find that exposing this internal representation type is not that great.
Contributor
Author
There was a problem hiding this comment.
it's already exposed though (cf taccoerce.mli)
Member
There was a problem hiding this comment.
Right. But I still feel like we're exposing more internal implementation details in the API after this PR.
Contributor
Author
There was a problem hiding this comment.
I don't think so
Contributor
Author
There was a problem hiding this comment.
added a commit to make tacvalue more abstract
SkySkimmer
added
the
request: full CI
SkySkimmer
force-pushed
the
wit-tac-value
branch
from
873a06a to
1130fd1
Compare
coqbot-app
bot
removed
the
request: full CI
Member
|
I only wish this PR has landed a week ago ;-) |
SkySkimmer
added
the
needs: overlay
SkySkimmer
added
the
request: full CI
SkySkimmer
force-pushed
the
wit-tac-value
branch
from
1130fd1 to
b6528af
Compare
coqbot-app
bot
removed
the
request: full CI
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.