Turn require Coq depr warnings as error by default#21851
Open
proux01 wants to merge 2 commits intorocq-prover:masterfrom
Open
Turn require Coq depr warnings as error by default#21851proux01 wants to merge 2 commits intorocq-prover:masterfrom
proux01 wants to merge 2 commits intorocq-prover:masterfrom
Conversation
proux01
added
kind: cleanup
coqbot-app
bot
removed
the
request: full CI
proux01
added
the
request: full CI
proux01
force-pushed
the
warnerror-require-coq
branch
from
8e19fdd to
d54ba77
Compare
coqbot-app
bot
removed
the
request: full CI
SkySkimmer
added
the
needs: overlay
SkySkimmer
approved these changes
Mar 31, 2026
proux01
added a commit
to rocq-community/bignums
that referenced
this pull request
Mar 31, 2026
proux01
added a commit
to rocq-community/atbr
that referenced
this pull request
Mar 31, 2026
proux01
added a commit
to rocq-community/bignums
that referenced
this pull request
Mar 31, 2026
proux01
added a commit
to proux01/fiat
that referenced
this pull request
Apr 1, 2026
proux01
added a commit
to proux01/Mtac2
that referenced
this pull request
Apr 1, 2026
proux01
added a commit
to proux01/paramcoq
that referenced
this pull request
Apr 1, 2026
proux01
added a commit
to rocq-community/paramcoq
that referenced
this pull request
Apr 1, 2026
Janno
added a commit
to Mtac2/Mtac2
that referenced
this pull request
Apr 1, 2026
proux01
added a commit
to proux01/smtcoq
that referenced
this pull request
Apr 1, 2026
proux01
added a commit
to rocq-community/stalmarck
that referenced
this pull request
Apr 1, 2026
proux01
added a commit
to rocq-community/stalmarck
that referenced
this pull request
Apr 1, 2026
proux01
added a commit
to rocq-community/stalmarck
that referenced
this pull request
Apr 1, 2026
proux01
added
the
request: full CI
proux01
force-pushed
the
warnerror-require-coq
branch
from
6bcaae9 to
0c97b2e
Compare
coqbot-app
bot
removed
the
request: full CI
nmvdw
added a commit
to UniMath/UniMath
that referenced
this pull request
Apr 2, 2026
Adapt to rocq-prover/rocq#21851 Co-authored-by: Niels van der Weide <nnmvdw@gmail.com>
proux01
added a commit
to proux01/coq-elpi
that referenced
this pull request
Apr 2, 2026
proux01
added
the
request: full CI
proux01
force-pushed
the
warnerror-require-coq
branch
from
0c97b2e to
5bae0b3
Compare
coqbot-app
bot
removed
the
request: full CI
gares
added a commit
to LPCIC/coq-elpi
that referenced
this pull request
Apr 2, 2026
proux01
added a commit
to proux01/hierarchy-builder
that referenced
this pull request
Apr 2, 2026
proux01
added a commit
to math-comp/hierarchy-builder
that referenced
this pull request
Apr 2, 2026
proux01
added
the
request: full CI
proux01
force-pushed
the
warnerror-require-coq
branch
from
5bae0b3 to
84c97af
Compare
coqbot-app
bot
removed
the
request: full CI
JasonGross
pushed a commit
to mit-plv/fiat
that referenced
this pull request
Apr 2, 2026
* Adapt to rocq-prover/rocq#21851 * Update CI 9.2.0 was released last week but we don't have the docker image yet.
JasonGross
pushed a commit
to proux01/rewriter
that referenced
this pull request
Apr 2, 2026
Member
|
What is the reason for this? (Is there any urgency?) Given the somewhat fluid boundary between corelib and stdlib, it seems much nicer to have a common prefix that can be used to refer to both of them. I was under the impression that the stdlib split was done somewhat tentatively, with the option to revert it if it seemed to do more harm than good. Has there been a debrief of the impacts of doing the split and which impacts are positive and which are negative? |
Contributor
Author
|
These deprecations date back from 9.0, planing actual removal in 9.4 is already way offer the official 2 successive versions compatibility policy. Note that you still have your common require prefix, it's just |
proux01
added a commit
to proux01/algebra-tactics
that referenced
this pull request
Apr 3, 2026
proux01
added a commit
to proux01/analysis
that referenced
this pull request
Apr 3, 2026
proux01
added a commit
to math-comp/analysis
that referenced
this pull request
Apr 3, 2026
proux01
added
the
request: full CI
proux01
force-pushed
the
warnerror-require-coq
branch
from
84c97af to
bf2dfa7
Compare
coqbot-app
bot
removed
the
request: full CI
Member
|
Dropping compatibility after two versions is fine for changes that are unambiguously positive, but you have not addressed my other question:
|
Contributor
Author
|
That's pretty orthogonal. The Even if you disagree, this is not yet removing the deprecation so you have one more release cycle to trigger any discussion you want to have. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overlays (to be merged before the current PR)