Slight cleanup in eq_constr_univs_test - #22455
Open
SkySkimmer wants to merge 1 commit into
Open
Conversation
Drop sigma = extended_evd alias, and use ESorts/EInstance.equal instead of Sorts/Instance.equal + kind (the E equal is just the non-E equal + kind so this does not change behaviour) IDK if checking Sorts.equal as a fast path in eq_sorts is actually useful but keeping it for now.
SkySkimmer
added
the
request: full CI
coqbot-app
Bot
removed
the
request: full CI
ppedrot
approved these changes
Sep 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Drop sigma = extended_evd alias, and use ESorts/EInstance.equal instead of Sorts/Instance.equal + kind (the E equal is just the non-E equal + kind so this does not change behaviour)
IDK if checking Sorts.equal as a fast path in eq_sorts is actually useful but keeping it for now.