Improve performance of GF2p2_Multiply in AES package#35
Open
MxAR wants to merge 1 commit intorod-chapman:masterfrom
Open
Improve performance of GF2p2_Multiply in AES package#35MxAR wants to merge 1 commit intorod-chapman:masterfrom
MxAR wants to merge 1 commit intorod-chapman:masterfrom
Conversation
This commit reimplements GF2p2_Multiply in a different way so that the function now takes 12 instead of 14 cycles to execute. This improvement is important, because this function gets called 480/672 times for every call to the AES-128/256 Cipher procedure.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit improves the implementation of the GF2p2_Multiply function in the AES package. The improved version of this function takes 12 instead of 14 cycles to execute. This improvement is significant, because this function gets called 480/672 times for every call to the AES-128/256 Cipher procedure.