Skip to content

Refactor: Rename persisted signal classes to correct typo #432

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rodydavis merged 1 commit into from
Dec 12, 2025
Merged

Refactor: Rename persisted signal classes to correct typo #432

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions packages/signals_core/lib/src/persisted/bool.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,9 +21,9 @@ class PersistedBoolSignal extends PersistedSignal<bool> {
}

/// A `PersistedSignal` that stores a nullable string value.
class PersistedPersistedBoolSignal extends PersistedSignal<bool?> {
/// Creates a new `PersistedBoolSignal`.
PersistedPersistedBoolSignal(
class PersistedNullableBoolSignal extends PersistedSignal<bool?> {
/// Creates a new `NullableBoolSignal`.
PersistedNullableBoolSignal(
super.val,
String key, {
SignalsKeyValueStore? store,
Expand Down
6 changes: 3 additions & 3 deletions packages/signals_core/lib/src/persisted/enum.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,10 +40,10 @@ class PersistedEnumSignal<T extends Enum> extends PersistedSignal<T>
}

/// A `PersistedSignal` that stores a nullable enum value.
class PersistedPersistedEnumSignal<T extends Enum> extends PersistedSignal<T?>
class PersistedNullableEnumSignal<T extends Enum> extends PersistedSignal<T?>
with _EnumPersistedSignal<T> {
/// Creates a new `PersistedEnumSignal`.
PersistedPersistedEnumSignal(
/// Creates a new `NullableEnumSignal`.
PersistedNullableEnumSignal(
super.val,
String key,
this.values, {
Expand Down
12 changes: 6 additions & 6 deletions packages/signals_core/test/persisted/signal_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,9 +50,9 @@ void main() {
});
});

group('PersistedPersistedBoolSignal', () {
group('PersistedNullableBoolSignal', () {
test('it should persist a nullable bool value', () async {
final signal = PersistedPersistedBoolSignal(true, 'nullable_bool_key');
final signal = PersistedNullableBoolSignal(true, 'nullable_bool_key');
await signal.init();
expect(signal.value, true);

Expand All @@ -61,7 +61,7 @@ void main() {
final item = await store.getItem('nullable_bool_key');
expect(item, '');

final signal2 = PersistedPersistedBoolSignal(true, 'nullable_bool_key');
final signal2 = PersistedNullableBoolSignal(true, 'nullable_bool_key');
await signal2.init();
expect(signal2.value, null);
});
Expand Down Expand Up @@ -122,9 +122,9 @@ void main() {
});
});

group('PersistedPersistedEnumSignal', () {
group('PersistedNullableEnumSignal', () {
test('it should persist a nullable enum value', () async {
final signal = PersistedPersistedEnumSignal(
final signal = PersistedNullableEnumSignal(
TestEnum.a,
'nullable_enum_key',
TestEnum.values,
Expand All @@ -137,7 +137,7 @@ void main() {
final item = await store.getItem('nullable_enum_key');
expect(item, '');

final signal2 = PersistedPersistedEnumSignal(
final signal2 = PersistedNullableEnumSignal(
TestEnum.a,
'nullable_enum_key',
TestEnum.values,
Expand Down