fix: only notify when the collection was modified.#435
Merged
rodydavis merged 4 commits intorodydavis:mainfrom Dec 12, 2025
Merged
fix: only notify when the collection was modified.#435rodydavis merged 4 commits intorodydavis:mainfrom
rodydavis merged 4 commits intorodydavis:mainfrom
Conversation
rodydavis
approved these changes
Dec 12, 2025
Owner
rodydavis
left a comment
rodydavis
left a comment
There was a problem hiding this comment.
This is a nice improvement! Thanks!
LGTM.
I believe List and Map both have this behavior
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currenly, every call to list.remove/set.remove notifies listeners even if nothing was removed.
I didn't do this for map because
map.removereturns null if the value wasn't in the map but map can allow null values so we are not sure if it was removed or not.edit:
I added the fix for map, it checks the length before and after to verify that the value was removed.