Skip to content

Conversation

@roerohan
Copy link
Owner

@roerohan roerohan commented Feb 24, 2025

Description

This PR adds support for React 19. Additionally, react-scripts and other create-react-app boilerplate is removed, instead vite is added as the hot module reload tool. vite also replaces rollup as the bundler in the new version to generate the esm and the umd (which should be compatible with cjs) build.

Resolved issues

Closes #64
Closes #61
Closes #58

Before submitting the PR, please take the following into consideration

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. If you don't have an issue, please create one.
  • Prefix your PR title with feat: , fix: , chore: , docs:, or refactor:.
  • The description should clearly illustrate what problems it solves.
  • Ensure that the commit messages follow our guidelines.
  • Resolve merge conflicts (if any).
  • Make sure that the current branch is upto date with the main branch.

BREAKING CHANGE: this will not work with older versions of react
@roerohan roerohan self-assigned this Feb 24, 2025
@roerohan
Copy link
Owner Author

Tested with local x11vnc server, seems to be working. Creating a release - this PR should make a major version bump leaving v2 of react-vnc unaffected.

@roerohan roerohan merged commit 44040fc into main Feb 24, 2025
3 checks passed
@roerohan roerohan deleted the feat-react-19 branch February 24, 2025 22:50
github-actions bot pushed a commit that referenced this pull request Feb 24, 2025
# [3.0.0](v2.0.3...v3.0.0) (2025-02-24)

* Merge pull request [#63](#63) from roerohan/feat-react-19 ([44040fc](44040fc))

### Bug Fixes

* remove rollup dep ([cec8373](cec8373))
* update husky config, remove rollup ([80a3dae](80a3dae))

### Features

* **react-19:** added support for react 19 ([d716043](d716043))

### BREAKING CHANGES

* feat: added support for react 19
* **react-19:** this will not work with older versions of react

skip-checks: true
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add support for React 19 react-scripts dependency breaks newer vite/ts projects

2 participants