Skip to content

Alternative archs build #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rubnogueira wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Alternative archs build #3

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
cf9f553
feat: add alternative releases
rubnogueira Oct 14, 2022
8e5357f
fix: remove i386 darwin
rubnogueira Oct 14, 2022
cc56f19
fix: remove darwin i386 build
rubnogueira Oct 14, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
39 changes: 26 additions & 13 deletions .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,13 +20,18 @@ jobs:

- name: Build from source
run: |
CGO_ENABLED=0 GOOS=linux GOARCH=amd64 go build -ldflags "-s -w" -o ./bin/wait-for-it
CGO_ENABLED=0 GOOS=linux GOARCH=386 go build -ldflags "-s -w" -o ./bin/wait-for-it.linux-386.exe
CGO_ENABLED=0 GOOS=linux GOARCH=amd64 go build -ldflags "-s -w" -o ./bin/wait-for-it-linux-amd64.exe
CGO_ENABLED=0 GOOS=linux GOARCH=arm64 go build -ldflags "-s -w" -o ./bin/wait-for-it-linux-arm64.exe
Comment on lines +23 to +25
Copy link
Owner

@roerohan roerohan Mar 20, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These should not end with .exe


- name: Upload artifact
- name: Upload artifacts
uses: actions/upload-artifact@v2
with:
name: wait-for-it
path: ./bin/wait-for-it
name: linux artifacts
path: |
./bin/wait-for-it.linux-i386
./bin/wait-for-it.linux-amd64
./bin/wait-for-it.linux-arm64
Comment on lines +32 to +34
Copy link
Owner

@roerohan roerohan Mar 20, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should also copy the wait-for-it.linux-arm64 binary to wait-for-it, since I've seen a couple of people use it in their docker containers directly from the releases on this repo. It would break for them if we don't have a binary called wait-for-it.


generate-windows:
name: Generate Windows binary
Expand All @@ -40,13 +45,18 @@ jobs:

- name: Build from source
run: |
CGO_ENABLED=0 GOOS=windows GOARCH=amd64 go build -ldflags "-s -w" -o ./bin/wait-for-it_win64.exe
CGO_ENABLED=0 GOOS=windows GOARCH=386 go build -ldflags "-s -w" -o ./bin/wait-for-it-windows-386.exe
CGO_ENABLED=0 GOOS=windows GOARCH=amd64 go build -ldflags "-s -w" -o ./bin/wait-for-it-windows-amd64.exe
CGO_ENABLED=0 GOOS=windows GOARCH=arm64 go build -ldflags "-s -w" -o ./bin/wait-for-it-windows-arm64.exe

- name: Upload artifact
- name: Upload artifacts
uses: actions/upload-artifact@v2
with:
name: wait-for-it_windows
path: ./bin/wait-for-it_win64.exe
name: windows artifacts
path: |
./bin/wait-for-it.windows-i386.exe
./bin/wait-for-it.windows-amd64.exe
./bin/wait-for-it.windows-arm64.exe

generate-mac:
name: Generate MacOS binary
Expand All @@ -60,13 +70,16 @@ jobs:

- name: Build from source
run: |
CGO_ENABLED=0 GOOS=darwin GOARCH=amd64 go build -ldflags "-s -w" -o ./bin/wait-for-it_mac
CGO_ENABLED=0 GOOS=darwin GOARCH=amd64 go build -ldflags "-s -w" -o ./bin/wait-for-it-darwin-amd64.exe
CGO_ENABLED=0 GOOS=darwin GOARCH=amd64 go build -ldflags "-s -w" -o ./bin/wait-for-it-darwin-arm64.exe
Comment on lines +73 to +74
Copy link
Owner

@roerohan roerohan Mar 20, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These should not end with .exe


- name: Upload artifact
- name: Upload artifacts
uses: actions/upload-artifact@v2
with:
name: wait-for-it_mac
path: ./bin/wait-for-it_mac
name: darwin artifacts
path: |
./bin/wait-for-it.darwin-amd64
./bin/wait-for-it.darwin-arm64


release:
Expand Down Expand Up @@ -130,6 +143,6 @@ jobs:
- name: Upload Release Asset
id: upload-release-asset
run: |
hub release edit -a ./bin/wait-for-it -a ./bin/wait-for-it_mac -a ./bin/wait-for-it_win64.exe -m "" ${{ env.VERSION }}
hub release edit -a ./bin/wait-for-it.linux-i386 -a ./bin/wait-for-it.linux-amd64 -a ./bin/wait-for-it.linux-arm64 -a ./bin/wait-for-it.windows-i386.exe -a ./bin/wait-for-it.windows-amd64.exe -a ./bin/wait-for-it.windows-arm64.exe -a ./bin/wait-for-it.darwin-amd64 -a ./bin/wait-for-it.darwin-arm64 -m "" ${{ env.VERSION }}
Copy link
Owner

@roerohan roerohan Mar 20, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add the wait-for-it binary here as well.

env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}