feat(object_detector): prepare object detector for config reload#1251
Merged
roflcoopter merged 1 commit intodevfrom Feb 13, 2026
Merged
feat(object_detector): prepare object detector for config reload#1251roflcoopter merged 1 commit intodevfrom
roflcoopter merged 1 commit intodevfrom
Conversation
✅ Deploy Preview for viseron canceled.
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR prepares the object_detector domain for config reload functionality by implementing proper entity tracking and cleanup mechanisms.
Changes:
- Added domain and identifier parameters to all add_entity calls for proper entity tracking
- Modified binary sensors to track event listeners in _event_listeners list for cleanup
- Added unload() method to AbstractObjectDetector for proper resource cleanup
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| viseron/domains/object_detector/zone.py | Added DOMAIN and camera_identifier parameters to entity registrations |
| viseron/domains/object_detector/binary_sensor.py | Modified all binary sensor classes to track event listeners in _event_listeners list |
| viseron/domains/object_detector/init.py | Added domain/identifier to entity registrations and implemented unload() method with thread cleanup |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.