Skip to content

Conversation

@roger-zhangg
Copy link
Owner

Problem

Adding metrics for Getting started project. Covering Walkthrough and AppBuilder to be added.

Solution

License

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

"description": "Whether or not AWS X-Ray is enabled"
},
{
"name": "appTemplateSelected",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason you made this a metric on it's own? Can we just include this in the metadata of "app_walkthroughSelectTemplate"?

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a metadata. We need to define metadata in order to use them in metrics.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I mean, can we not say inside of the "app_walkthroughSelectTemplate" metric

"metadata": [
                {
                    "type": "template",
                    "required": true
                },

and have the value of "template": "s3_resizing" / "rest_api_hello_world" or something like that?

Copy link

@seshubaws seshubaws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For all of these metrics, can we add a metadata with "section: app_playground"? We want to add this metadata to the already existing metrics as well (when we implement them in the new code we write) so that we can easily compile all the metrics related to app playground in one dashboard.

@roger-zhangg
Copy link
Owner Author

roger-zhangg commented Jul 30, 2024

Do you mean add a metadata to existing metrcis to indicate it's emitted by our fucntion? So the metadata name will be section and value could be empty or app_playground ?

@seshubaws
Copy link

LGTM! Can you make a PR to the main https://github.com/aws/aws-toolkit-common repo?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants