Telemetry for getting started project #1
Conversation
| "description": "Whether or not AWS X-Ray is enabled" | ||
| }, | ||
| { | ||
| "name": "appTemplateSelected", |
There was a problem hiding this comment.
Is there a reason you made this a metric on it's own? Can we just include this in the metadata of "app_walkthroughSelectTemplate"?
There was a problem hiding this comment.
This is a metadata. We need to define metadata in order to use them in metrics.
There was a problem hiding this comment.
I mean, can we not say inside of the "app_walkthroughSelectTemplate" metric
"metadata": [
{
"type": "template",
"required": true
},
and have the value of "template": "s3_resizing" / "rest_api_hello_world" or something like that?
seshubaws
left a comment
seshubaws
left a comment
There was a problem hiding this comment.
For all of these metrics, can we add a metadata with "section: app_playground"? We want to add this metadata to the already existing metrics as well (when we implement them in the new code we write) so that we can easily compile all the metrics related to app playground in one dashboard.
|
Do you mean add a metadata to existing metrcis to indicate it's emitted by our fucntion? So the metadata name will be |
|
LGTM! Can you make a PR to the main https://github.com/aws/aws-toolkit-common repo? |
…o getting-started
Problem
Adding metrics for Getting started project. Covering Walkthrough and AppBuilder to be added.
Solution
License
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.