fix: write after rotateStream destroyed#73
Open
SunshowerC wants to merge 1 commit intorogerc:masterfrom
Open
Conversation
should not write when rotateStream has been destroyed, avoiding this case: winstonjs/winston-daily-rotate-file#226
|
@rogerc Could you PTAL? |
Owner
|
@SunshowerC thanks for the PR, however this seems to be an issue with process specific logging rather than routing all logging through the parent process. Just silencing the error is not really a good fix. Silencing the error discarding the data that should be logged and not deal with the root cause is not what users would expect. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
should not write when rotateStream has been destroyed.
It would fix this bug: winstonjs/winston-daily-rotate-file#226