Skip to content

Use dd command instead of test command to wait the Serial device #297

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Use dd command instead of test command to wait the Serial device #297

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7e543fc
Use dd command instead of test command to wait the Serial device
hanyazou Jun 2, 2017
1902867
Add wait loop after upload-reset instead of fixed delay
hanyazou Oct 22, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion tools/macosx/maple_upload
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ ${DFU_UTIL} -d ${usbID} -a ${altID} -D ${binfile} -R ${dfuse_addr} -R
echo -n Waiting for ${dummy_port_fullpath} serial...

COUNTER=0
while [ ! -c ${dummy_port_fullpath} ] && ((COUNTER++ < 40)); do
while ! dd if=${dummy_port_fullpath} of=/dev/null count=0 > /dev/null 2>&1 && ((COUNTER++ < 40)); do
Copy link
Contributor

@kolyshkin kolyshkin Feb 6, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Can you please explain why using dd is better than a built-in check (test -c)? I mean, device existence should be enough, there's no need to try opening it for reading.

  2. The same change is needed for linux (at least).

Copy link
Contributor Author

@hanyazou hanyazou Feb 17, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. I mean, device existence should be enough, there's no need to try opening it for reading.

Because it does not have read permission though the device exist or you can't open the device for read though it have read permission. Please note that some device driver might return EACCESS on open operation even if the device entry on the file system have the permission.

  1. The same change is needed for linux (at least).

I can't test that modification because I don't have Linux PC. If you get device open error on your Linux, please try this patch.

sleep 0.1
done

Expand Down