use github actions for CI #58
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rogpeppe
force-pushed
the
025-github-actions
branch
4 times, most recently
from
babd9c2 to
20a35b9
Compare
myitcv
reviewed
Aug 21, 2019
| runs-on: ${{ matrix.platform }} | ||
| steps: | ||
| - name: Install Go | ||
| uses: actions/setup-go@v1 |
Collaborator
There was a problem hiding this comment.
Behind this innocuous looking line lies dragons:
https://github.com/actions/setup-go/blob/master/src/installer.ts
What was wrong with wget?
Collaborator
There was a problem hiding this comment.
Travis had gimme, which was equally a big hack in bash.
Ultimately you can't just rely on wget, because that won't easily support many platforms, and "latest" versions like 1.12.x.
Honestly, I don't care what setup-go does, as long as it works :)
rogpeppe
force-pushed
the
025-github-actions
branch
2 times, most recently
from
e6ced00 to
31686f5
Compare
rogpeppe
force-pushed
the
025-github-actions
branch
from
31686f5 to
5c78d95
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.