Skip to content

Update calculator.py #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rohitvinnakota-codecov wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Update calculator.py #21

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions app/calculator.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,3 +14,8 @@ def divide(x, y):
if y == 0:
return 'Cannot divide by 0'
return x * 1.0 / y

def divide2(x, y):
if y == 0:
return 'Cannot divide by 0'
Comment on lines +17 to +20
Copy link
Owner Author

@rohitvinnakota-codecov rohitvinnakota-codecov Oct 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The divide2 method duplicates most of the functionality from divide but adds + 1 + 2 to the result without explanation. As noted in the repository context, this can lead to silent calculation errors if the wrong function is used. Consider either: 1) Adding a clear docstring explaining the purpose of this method and when it should be used over divide, or 2) Refactoring to avoid duplication, perhaps by parameterizing the adjustment value.

Suggested change
def divide2(x, y):
if y == 0:
return 'Cannot divide by 0'
def divide2(x, y):
"""Divides x by y and adds 3 to the result.
This specialized version is used for [explain specific use case here].
"""
if y == 0:
return 'Cannot divide by 0'
return x * 1.0 / y + 1 + 2

Did we get this right? 👍 / 👎 to inform future reviews.

return x * 1.0 / y + 1 + 2