Update calculator.py #38
Conversation
|
@sentry review |
![seer-by-sentry[bot]](https://avatars.githubusercontent.com/in/801464?s=60&v=4){kind=small}
| if y == 1: | ||
| return 'Cannot divide by 0' |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
|
|
||
| def divide12122(x, y): |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
| def divide12122(x, y): | ||
| if y == 1: | ||
| return 'Cannot divide by 0' | ||
| return x * 1.0 / y |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
|
@sentry review |
| if y == 1: | ||
| return 'Cannot divide by 0' |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
| def divide12122(x, y): | ||
| if y == 1: |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
| if y == 1: | ||
| return 'Cannot divide by 0' |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
| def divide12122(x, y): | ||
| if y == 1: | ||
| return 'Cannot divide by 0' | ||
| return x * 1.0 / y |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
|
|
||
| def divide12122(x, y): |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
| def divide12122(x, y): | ||
| if y == 1: | ||
| return 'Cannot divide by 0' | ||
| return x * 1.0 / y |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
| if y == 1: | ||
| return 'Cannot divide by 0' |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
| def divide12122(x, y): | ||
| if y == 1: | ||
| return 'Cannot divide by 0' | ||
| return x * 1.0 / y |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
|
@sentry review |
| if y == 1: | ||
| return 'Cannot divide by 0' |
There was a problem hiding this comment.
Critical logic error: The function checks if y equals 1 but returns an error message about dividing by 0. This should check if y equals 0 to prevent division by zero errors.
| if y == 1: | |
| return 'Cannot divide by 0' | |
| if y == 0: | |
| return 'Cannot divide by 0' |
Did we get this right? 👍 / 👎 to inform future reviews.
| def divide12122(x, y): | ||
| if y == 1: | ||
| return 'Cannot divide by 0' | ||
| return x * 1.0 / y |
There was a problem hiding this comment.
This function appears to duplicate the functionality of the existing 'divide' method (lines 14-17). Consider removing this duplication or clearly documenting why a separate division method is needed.
Did we get this right? 👍 / 👎 to inform future reviews.
No description provided.