Skip to content

Raise error when subthreads fail. #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
exceedhl wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Raise error when subthreads fail. #1

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e94dbda
Version bump to 0.1.3
exceedhl Jan 9, 2012
846f360
Raise error when subthreads fail.
exceedhl Jan 9, 2012
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion VERSION.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
---
:minor: 1
:patch: 2
:patch: 3
:major: 0
:build:
7 changes: 5 additions & 2 deletions lib/capistrano/configuration/extensions/actions/invocation.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,7 @@
module Capistrano

ParallelError = Class.new(Capistrano::Error)

class Configuration
module Extensions
module Actions
Expand Down Expand Up @@ -34,7 +37,7 @@ def run_parallelize_loop(proxy, thread_count)
threads = run_in_threads(chunk)
all_threads << threads
wait_for(threads)
rollback_all_threads(all_threads.flatten) and return if threads.any? {|t| t[:rolled_back] || t[:exception_raised]}
rollback_all_threads(all_threads.flatten) and raise ParallelError.new("Subthread failed in parallel running, rolled back.") if threads.any? {|t| t[:rolled_back] || t[:exception_raised]}
batch += 1
end
all_threads
Expand Down Expand Up @@ -81,4 +84,4 @@ def rollback_all_threads(threads)
end
end
end
end
end