Support RunContext and update to rbx-dom v3.0.0#97
Open
Ransomwave wants to merge 2 commits intorojo-rbx:masterfrom
Open
Support RunContext and update to rbx-dom v3.0.0#97Ransomwave wants to merge 2 commits intorojo-rbx:masterfrom
Ransomwave wants to merge 2 commits intorojo-rbx:masterfrom
Conversation
I focused this PR on adding RunContext support, but I've also done minor improvements to the codebase - Add RunContext property detection and preservation for Script instances - Update rbx-dom dependencies to latest versions (v3.0.0) - required for RunContext support - Add ustr dependency for string handling - required by rbx-dom v3.0.0 API - Preserve RunContext in meta.json files with string serialization - Improve filesystem operations with parent directory creation - prevents crashes - Add cross-platform line ending normalization - fixes test failures on Windows - Update API calls for rbx-dom v3.0.0 compatibility - required due to API changes Scripts with a RunContext property use a ".server.lua" extension with the RunContext preserved in meta.json when present. The dependency updates are necessary because RunContext property support was not available in the previous alpha versions. The API compatibility changes are required due to breaking changes in rbx-dom v3.0.0 (removal of deprecated methods).
Author
|
Apparently this PR fixes the "Decompression failed. Input invalid or too long?" issue when trying to use the tool with a |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I focused this PR on adding RunContext support, but I've also done minor improvements to the codebase
.luauextensionScripts with a RunContext property use a ".server.lua" extension with the RunContext preserved in meta.json when present.
The dependency updates are necessary because RunContext property support was not available in the previous alpha versions. The API compatibility changes are required due to breaking changes in rbx-dom v3.0.0 (removal of deprecated methods).