Use buffer for ClassIcon EditableImages#1149
Merged
Dekkonot merged 7 commits intorojo-rbx:masterfrom Nov 7, 2025
Merged
Conversation
Dekkonot
added
scope: plugin
Dekkonot
requested changes
Nov 6, 2025
Member
Dekkonot
left a comment
Dekkonot
left a comment
There was a problem hiding this comment.
- Please run StyLua on this so that CI passes
- The style for this codebase is camelCase. Please swap your new function and variables to camelCase.
Dekkonot
previously approved these changes
Nov 7, 2025
Member
|
Selene is mad about you shadowing some variables, which I did not see before I approved this. Probably need to fix that, whether by disabling that lint in-line or just not shadowing the variables. |
Dekkonot
approved these changes
Nov 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Makes the ClassIcon component now use the EditableImage buffer API, instead of the old depricated table based writing API.