Skip to content

Remove pairs() and ipairs()#1150

Merged
Dekkonot merged 2 commits intorojo-rbx:masterfrom
gaymeowing:remove-pairs
Nov 19, 2025
Merged

Remove pairs() and ipairs()#1150
Dekkonot merged 2 commits intorojo-rbx:masterfrom
gaymeowing:remove-pairs

Conversation

@gaymeowing
Copy link
Copy Markdown
Contributor

Removes legacy usage of pairs() and ipairs(), didn't fully touch EncodedValue because it seems like it relies on ipairs() only iterating over the array part for some of it.

@Dekkonot Dekkonot added scope: plugin Relevant to the Roblox Studio plugin type: tech debt Internal work that needs to happen skip changelog PRs that may skip the changelog enforcement check labels Nov 7, 2025
Copy link
Copy Markdown
Member

@Dekkonot Dekkonot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rbx_dom_lua is sourced from rbx-dom. Changes to it will need to be done upstream and then the next time we update rbx_dom_lua it will be changed in this repository.

Otherwise, looks good.

@Dekkonot Dekkonot merged commit 31ec216 into rojo-rbx:master Nov 19, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

scope: plugin Relevant to the Roblox Studio plugin skip changelog PRs that may skip the changelog enforcement check type: tech debt Internal work that needs to happen

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants