Fix rojo plugin install by adding Vfs::exists#1169
Merged
Dekkonot merged 4 commits intorojo-rbx:masterfrom Nov 21, 2025
Merged
Conversation
Dekkonot
approved these changes
Nov 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #1159, we added a new helper function for loading a project file:
rojo/src/project.rs
Lines 291 to 307 in 2b47861
At line 298, we use
Path::exists. This doesn't work at all when we're using the in memory file system, or in general, because the virtual file system need not have any correspondence to the host's file system. This causes therojo plugin installcommand to always fail, because it uses the in memory file system to build the plugin RBXM.This PR fixes this problem by adding a
Vfs::existsmethod that is equivalent tostd::fs::exists, and using it inload_initial_project. It also adds a smoke test to the plugin install command to ensure the plugin initializes correctly.I also moved the
create_dirandcreate_dir_allmemofs changelog entry under the unreleased header, because that change has not made it into a memofs release yet, and we missed this during review.