Skip to content

Comments

Fixes How BinaryOperators work on Unions#1400

Merged
markwpearce merged 5 commits intorelease-1.0.0from
fix_binaryoperators_on_unions
Jan 14, 2025
Merged

Fixes How BinaryOperators work on Unions#1400
markwpearce merged 5 commits intorelease-1.0.0from
fix_binaryoperators_on_unions

Conversation

@markwpearce
Copy link
Collaborator

@markwpearce markwpearce commented Jan 14, 2025

New logic:

  • the result of a binary op on unions depends on what types are in the union
  • Basically, the "highest priority" type wins
  • If two types are "equal priority", but not the same, treat it as Dynamic
  • (float or integer) + (Integer) => Float
  • Treats "ObjectType" basically like "DynamicType"

@markwpearce markwpearce added this to the v1.0.0 milestone Jan 14, 2025
@markwpearce
Copy link
Collaborator Author

fixes #1396

@markwpearce markwpearce merged commit 7fb92ff into release-1.0.0 Jan 14, 2025
6 checks passed
@markwpearce markwpearce deleted the fix_binaryoperators_on_unions branch January 14, 2025 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant