Skip to content

Perfetto controls #285

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
JyotiBurnwal1 wants to merge 6 commits into from
Closed

Perfetto controls #285

JyotiBurnwal1 wants to merge 6 commits into from

Conversation

@JyotiBurnwal1
Copy link
Contributor

@JyotiBurnwal1 JyotiBurnwal1 commented Jan 6, 2026

This PR has the feature to enable perfetto controls via config.

sample config:

    "profiling": {
      "enable": true,
      "dir": "${workplace}/profiling",
      "filename": "${appTitle}_${timestamp}.profile"
    },

ramkav
ramkav reviewed Jan 7, 2026
View reviewed changes
src/ECP.spec.ts Outdated
import * as sinonActual from "sinon";
let sinon = sinonActual.createSandbox();

describe("ECP", () => {
Copy link

@ramkav ramkav Jan 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this file be Perfetto.spec.ts, and the string in the describe call be "Perfetto" instead of "ECP"?

@TwitchBronBron TwitchBronBron mentioned this pull request Jan 15, 2026
Draft
@JyotiBurnwal1
Copy link
Contributor Author

JyotiBurnwal1 commented Jan 21, 2026

Closing because we have a similar PR - #286

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@ramkav ramkav ramkav left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@JyotiBurnwal1 @ramkav