Feature/turn off internal fingerprinting#77
Open
ORESoftware wants to merge 5 commits intorollbar:masterfrom
Open
Feature/turn off internal fingerprinting#77ORESoftware wants to merge 5 commits intorollbar:masterfrom
ORESoftware wants to merge 5 commits intorollbar:masterfrom
Conversation
pawelsz-rb
reviewed
Jun 14, 2022
Collaborator
pawelsz-rb
left a comment
There was a problem hiding this comment.
I think we are introducing more methods. Can we use our existing fingerprinting method and add another optional parameter to indicate we want it from the client?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the change
The problem is that "SetFingerprint(v bool)" makes it seem like you are setting the fingerprint value for all items or something, which doesnt make sense.
We should make it more obvious for users to turn on / turn off internal fingerprinting. In my case, I prefer the SDK with my own fingerprint value that I generate manually, so I don't want the Go lib to do the unnecessary work of getting line numbers / filenames from the runtime - I want to turn off all internal fingerprinting, since I use these:
and then my fingerprint rules are like so:
[ { "condition": { "contains": "fingerprint", "path": "custom" }, "fingerprint": "{{custom.fingerprint}}", "title": "{{default_title}}" } ]Gianina from Rollbar support says:
So I guess the fingerprint is created on rollbar servers, not the client, which is pretty intense - I would think that rollbar would do that in the client runtime, and not overburden their servers!
Development
Code review