Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion src/browser/replay/recorder.js
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ import { EventType } from '@rrweb/types';

import hrtime from '../../tracing/hrtime.js';
import logger from '../../logger.js';
import defaults from './defaults.js';

/** @typedef {import('./recorder.js').BufferCursor} BufferCursor */

Expand Down Expand Up @@ -97,7 +98,11 @@ export default class Recorder {
* @returns {number} Checkout interval in milliseconds
*/
checkoutEveryNms() {
return ((this.options.maxSeconds || 10) * 1000) / 2;
const maxSeconds =
this.options.maxSeconds > 0
? this.options.maxSeconds
: defaults.maxSeconds;
return (maxSeconds * 1000) / 2;
}

/**
Expand Down
16 changes: 14 additions & 2 deletions test/replay/unit/recorder.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -159,17 +159,29 @@ describe('Recorder', function () {
expect(recorder.checkoutEveryNms()).to.equal(5000);
});

it('uses default of 10 seconds when maxSeconds not provided', function () {
it('uses default of 300 seconds when maxSeconds not provided', function () {
const recorder = new Recorder({}, mockRecordFn);

expect(recorder.checkoutEveryNms()).to.equal(5000);
expect(recorder.checkoutEveryNms()).to.equal(150000);
});

it('calculates correctly for different maxSeconds values', function () {
const recorder = new Recorder({ maxSeconds: 20 }, mockRecordFn);

expect(recorder.checkoutEveryNms()).to.equal(10000);
});

it('uses default when maxSeconds is 0', function () {
const recorder = new Recorder({ maxSeconds: 0 }, mockRecordFn);

expect(recorder.checkoutEveryNms()).to.equal(150000);
});

it('uses default when maxSeconds is negative', function () {
const recorder = new Recorder({ maxSeconds: -5 }, mockRecordFn);

expect(recorder.checkoutEveryNms()).to.equal(150000);
});
});

describe('_previousSlot', function () {
Expand Down
Loading