Add ReplayManager.triggerReplay #1359
Merged
+136
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
Adds
triggerReplay
method to ReplayManager, with different requirements than the occurrence-centriccapture
andsendOrDiscardReplay
.send
immediately after export, and therefore awaits export.triggerReplay
is async so that it can be non-blocking for the caller and also return the replayId when it succeeds._canSendReplay
.There may be an opportunity to refactor
triggerReplay
andcapture
to use more shared code. This PR doesn't attempt to solve that. It enables the needed triggers in the short term, allowing more time to consider a preferred refactoring.Type of change
Checklists
Development