Skip to content

Option to ignore SSL certificate#397

Merged
rom1504 merged 8 commits intorom1504:mainfrom
theophilegervet:option_to_ignore_ssl_certificate
Aug 16, 2025
Merged

Option to ignore SSL certificate#397
rom1504 merged 8 commits intorom1504:mainfrom
theophilegervet:option_to_ignore_ssl_certificate

Conversation

@theophilegervet
Copy link
Copy Markdown
Contributor

No description provided.

@davertor
Copy link
Copy Markdown

@rom1504 It would be nice to have the ignore_ssl_certificate option soon for avoiding SSL errors when downloading any dataset. What modifications are still needed to merge this PR into main?

@npip99
Copy link
Copy Markdown

npip99 commented Aug 16, 2025

Can we please merge this? For users to enforce MD5 hash matching, this PR is really a pure gain with no downsides.

@rom1504
Copy link
Copy Markdown
Owner

rom1504 commented Aug 16, 2025

Ok ; I'll add docs and tests later today then will merge

…feature

- Add ignore_ssl_certificate parameter documentation to README with usage examples and security warnings
- Add comprehensive test coverage including SSL error simulation and bypass validation
- Fix pylint deprecation warning for imghdr module
- Tests verify SSL context configuration and actual error handling scenarios

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>
@rom1504 rom1504 merged commit 95523bc into rom1504:main Aug 16, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants