Conversation
kostasrim
commented
Dec 11, 2025
| ec = StatX(path.c_str(), &stat, wf->fd()); | ||
| ASSERT_FALSE(ec); | ||
| ASSERT_EQ(stat.stx_size, 0); | ||
| ASSERT_EQ(stat.stx_blocks, 0); |
Collaborator
Author
There was a problem hiding this comment.
This fires but I don't understand why 🤔
const int mode = FALLOC_FL_PUNCH_HOLE | FALLOC_FL_KEEP_SIZE;
Means that we will punch a hole on all the blocks so at least we should see a reduction yet it does not change at all 🤔
Based on my understanding, PUCH_HOLE is not hint meaning that we should see a reduction in block size
Owner
There was a problem hiding this comment.
I do not know but I would first use fallocate + stat shell commands and play with them. no need to write code to explore their behavior
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Plz read the comments in the code (see my review)