-
Notifications
You must be signed in to change notification settings - Fork 54
Clean database and converters #118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This will show: - correct image - correct name & link to device
c4bea52 to
a2f5c9b
Compare
bc53467 to
2266d69
Compare
I'm currently working on a solution to generate z2m "exposes" based on device config directly inside the converter. Idea here that changing the config should update the Z2M UI, and should not rely on the exact model/manufacturer string. So I'm not sure you should do this change now, as my change will probably be in conflict. |
|
That sounds interesting.. didn't know we could do that! Does that mean we'll have a single converter that adapts to every device? |
Yes! I finally got it working. It still needs some polishing, but hopefully I’ll open a PR tomorrow. |
(reference to original device)
2266d69 to
52048e5
Compare
and adjust scripts accordingly
(ZTU, ZT3L, ZT2S)
into tuya_manufacturer_name and old_manufacturer_names; adjust scripts
|
Here is the generic converter: #120 |
romasku
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Current changes look very good!
Thank you for doing this work. I really appreciate you going through the device list and adding links, modules, and also cleaning up the build process to avoid duplication.
Maybe you have some additional ideas in mind here, but regarding whiteLabels from Z2M, I don’t think that’s an option for us -- in addition to different branding, white labels often have different pinouts. |
|
I just wanted to automatically get the value for override_z2m_device. Currently we have to manually search through official Z2M converters and add it in the database (to get the correct device name and picture). Glad you like the changes! Please merge this. |
|
Thank you! |
I am working on cleaning the database as discussed in #110:
standardize the converters and reuse themtuya_manufacturer_namesinto tuya name and old fw namesI will do each task in a separate commit so it's easier to review