Skip to content

Conversation

@andrei-lazarov
Copy link
Collaborator

@andrei-lazarov andrei-lazarov commented Aug 14, 2025

I am working on cleaning the database as discussed in #110:

  • show correct Z2M model and picture with the rebranded model names (overwrite with whiteLabel)
  • remove duplicate name (the name field is not used anywhere, we already have the name in the key and in the human_name field)
  • automate some processes so we minimize the information needed in the database (eg. get the whiteLabels from original Z2M converters)
  • use original manufacturer name in the custom firmware so we keep a reference to the original device
  • standardize the converters and reuse them
  • add Zigbee board in the database (ZTU, ZT3L etc) - seems useful, I would use it in the converters to prevent impossible pinouts
  • add AliExpress link in the db?
  • split tuya_manufacturer_names into tuya name and old fw names
  • combine router and end_device entries

I will do each task in a separate commit so it's easier to review

This will show:
- correct image
- correct name & link to device
@romasku
Copy link
Owner

romasku commented Aug 15, 2025

standardize the converters and reuse them

I'm currently working on a solution to generate z2m "exposes" based on device config directly inside the converter. Idea here that changing the config should update the Z2M UI, and should not rely on the exact model/manufacturer string. So I'm not sure you should do this change now, as my change will probably be in conflict.

@andrei-lazarov
Copy link
Collaborator Author

That sounds interesting.. didn't know we could do that! Does that mean we'll have a single converter that adapts to every device?

@romasku
Copy link
Owner

romasku commented Aug 16, 2025

Does that mean we'll have a single converter that adapts to every device?

Yes! I finally got it working. It still needs some polishing, but hopefully I’ll open a PR tomorrow.

(reference to original device)
@romasku
Copy link
Owner

romasku commented Aug 18, 2025

Here is the generic converter: #120

Copy link
Owner

@romasku romasku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Current changes look very good!

Thank you for doing this work. I really appreciate you going through the device list and adding links, modules, and also cleaning up the build process to avoid duplication.

@romasku
Copy link
Owner

romasku commented Aug 18, 2025

automate some processes so we minimize the information needed in the database (eg. get the whiteLabels from original Z2M converters)

Maybe you have some additional ideas in mind here, but regarding whiteLabels from Z2M, I don’t think that’s an option for us -- in addition to different branding, white labels often have different pinouts.

@andrei-lazarov andrei-lazarov marked this pull request as ready for review August 18, 2025 22:24
@andrei-lazarov
Copy link
Collaborator Author

I just wanted to automatically get the value for override_z2m_device.

Currently we have to manually search through official Z2M converters and add it in the database (to get the correct device name and picture).
So nothing pinout related. Since you already reviewed, I'll do it later in another PR.

Glad you like the changes! Please merge this.
Also go through your devices (when you have the time) to fill in the zb_module.

@romasku romasku merged commit 0a42f2d into romasku:main Aug 19, 2025
@romasku
Copy link
Owner

romasku commented Aug 19, 2025

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants