-
Notifications
You must be signed in to change notification settings - Fork 51
Add software PWM LED dimming support for Router builds #140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…mplifying initialization
- Resolved conflicts in src/configs/nv_slots_cfg.h by keeping main structure and adding PWM config - Resolved conflicts in zigbee2mqtt/converters/switch_custom.js by merging PWM features with main changes - Maintained existing code style and structure - Added network indicator support and binded mode features from main - Preserved PWM LED dimming functionality from enhancement branch
Hi, thanks for your interest in the project. There isn't a process. I just don't know how to react to this. I can point out a couple of things:
I kindly suggest you let more experienced contributors tackle this feature. You can join the Discord server for quicker updates about the project and seeking what we are currently working on. I personally focus on welcoming more users, replying to everyone, trying to grow the team and supporting more devices. Thanks for understanding! |
…-support # Conflicts: # docs/supported_devices.md
Hi, thank you for taking the time to review and share your perspective. I’d like to clarify a couple of things about how I approached this:
I appreciate your note that this project is niche, that AI can hallucinate, and that mistakes here could be costly given the flashing constraints. I completely understand why you’d prefer someone more experienced to take this forward. That said, I’ll look at addressing some of your comments regardless—even if this PR isn’t merged, it may still serve as a reference for future work. Thanks again for the feedback, and for all the effort you and the team put into maintaining and growing the project. |
|
In that case you should order a flashing adapter and a spare switch so you can start testing your changes. If you want to avoid soldering, I think you can get a development board (I didn't test these yet). But anyway your switch should have an exposed header where you can easily connect VCC and GND. |
… entries and removing unnecessary fields
|
@andrei-lazarov - I have not had a chance to buy or test using a hardware device but I did action the feedback from your comments and pushed the new changes - hopefully it will be of some use! |
|
Hi @andrei-lazarov - I've not had time to test this with a new job and a baby! Looks like the merge conflicts are building up though 🙈 |
🎯 Overview
Adds software PWM LED dimming for indicator LEDs on Router builds, providing 16 discrete brightness levels (0-15) at 500Hz. Users can now control indicator LED brightness through Zigbee2MQTT and ZHA.
I don't have a hardware flasher and cannot test this on actual devices. The implementation compiles successfully and passes all unit tests, but needs community testing on real hardware before merge.
✨ Key Features
🐳 Docker Support Added
Added containerized build environment since I'm on Windows and couldn't build natively:
Dockerfile+docker-compose.ymlfor cross-platform builds📱 Supported Devices
MOES_2_GANG_SWITCH) - Router build only🔧 Zigbee Integration
New Attributes:
0xff03- PWM Enable/Disable (Boolean)0xff04- PWM Brightness (0-15)Home Assistant Entities:
switch.device_relay_indicator_pwm_modenumber.device_relay_indicator_pwm_brightness🏗️ Implementation
src/base_components/led_pwm.{c,h}indicator_pwm: trueflagINDICATOR_PWM_SUPPORT📚 Documentation
docs/pwm_led_dimming.md- Feature guidedocs/zha_pwm_integration.md- ZHA setupdocs/building.md- Updated with Docker instructions🔄 Backward Compatibility
🙏 Community Testing Needed
Since I can't test on hardware, please help verify: