[ROMM-1863] Set default bios file in config.yml

[gantoine]

Description
^{Explain the changes or enhancements you are proposing with this pull request.}

Pass a filename for each emulator core via config.yml and we'll use by default for all players:

emulatorjs:
  settings:
    mgba:
      bios_file: gba_bios.bin

Fixes #1863

Checklist
^{Please check all that apply.}

• I've tested the changes locally
• I've updated relevant comments
• I've assigned reviewers for this PR
• I've added unit tests that cover the changes

Screenshots (if applicable)

[gemini-code-assist]

Summary of Changes

Hello @gantoine, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the emulator configuration by allowing a default BIOS file to be specified per emulator core directly within the config.yml. This change simplifies the setup for users by automatically selecting a pre-configured BIOS if one isn't explicitly chosen, improving the out-of-the-box experience and reducing manual configuration steps.

Highlights

• Configurable Default BIOS: Introduced the ability to specify a default BIOS file for emulator cores in config.yml using the emulatorjs.settings.<core_name>.bios_file path.
• BIOS Selection Logic Update: Modified the BIOS selection process in Play.vue to first check for a user-selected BIOS and then fall back to the config.yml defined default if available.
• Player Initialization Enhancement: Updated Base.vue to apply the default BIOS file from config.yml during player initialization, ensuring the correct BIOS is pre-selected.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request adds functionality to set a default BIOS file for emulator cores via config.yml. The changes correctly implement this feature in both the game player setup screen and the console game launcher.

My review includes suggestions to improve the robustness and maintainability of the new logic. Specifically, I've pointed out a potential type-safety issue and code duplication between two components. Addressing these points will make the code cleaner and less prone to future bugs.

[gantoine]

/gemini review

[gemini-code-assist]

Code Review

This pull request adds a feature to set a default BIOS file for emulator cores via config.yml. The changes are implemented correctly in both the console and main web UI player views. My main feedback is to refactor the duplicated logic for determining the BIOS into a shared utility function to improve maintainability. This also presents an opportunity to make the code slightly more robust.