Open
Conversation
pawiecz
previously requested changes
Mar 9, 2026
Contributor
|
@TomHawk123 it looks like the I'll submit locking the |
Used safe var helper to ensure proper integer is being used for GraphQL depth Using Node 24.14.0, as directed to make CI happy
juanmrad
reviewed
Mar 13, 2026
pawiecz
reviewed
Mar 16, 2026
Contributor
pawiecz
left a comment
There was a problem hiding this comment.
Patch looks good!
I'll merge #112 so we could address the CI warning.
Author
I don't think I can merge until @juanmrad approves the PR after addressing his change request and/or until the CI warning can be addressed. |
juanmrad
approved these changes
Mar 19, 2026
Member
|
@TomHawk123 can you merge main to re-trigger CI and make sure all passes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context & Requests for Reviewers
This PR answers Issue #108
Tests
Ran locally and slammed the server with an overly complex query to confirm crashing of service. Implemented depth limit of 10 and tested:
Expected to Fail:
Expected to Succeed:
(Optional) Rollout Plan
After testing by reviewers, this should be able to rollout immediately.