-
Notifications
You must be signed in to change notification settings - Fork 85
Add treemap #367
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add treemap #367
Conversation
|
I change to Can you move your files to Also in your file you have |
Why is this needed? I don't think we ever want to store a TreeMapPainter in a ROOT file |
af4d07d to
de95d16
Compare
|
Moved files in |
While then I can add it to JSROOT CI tests - see here: https://github.com/root-project/jsroot/actions/runs/17647937723/job/50150808637#step:10:1 |
I still don't understand. Does Patryk need to provide a ROOT file containing a TreeMapPainter? How is this ROOT file used exactly? |
Yes.
It will be add to set of our examples https://root.cern/js/latest/examples.htm and regularly checked. |
|
This compressed root file should have an RTreeMapPainter instance inside: |
This is exactly that I need. I test code locally on my machine and if it works as expected I will merge PR and add file to jsroot testing |
getComputedTextLength not exists there, one can use jsroot functionality later
|
I add several commits to fix several problems. |
|
There are many eslint warnings about coding conventions. You can fix them later if you want. |
|
Here how file is integrated into CI: https://github.com/linev/jsroot-test/blob/master/Misc/treemap.svg And this is how it shown in my dev environment: |
|
And after merging of this PR. One can write JavaScript code to directly display RNTuple from JSROOT. |
I fixed them by running eslint fix on the corresponding files |
treemapmodule injswithRTreeMapPainter.mjsandRTreeMapToolTip.mjsthat constitute:I am still a little confused about the ROOT file I need to attach for testing purposes. Since the
RTreeMapvisualization is available for any ROOT file with an RNTuple, is it okay if I just attach a ROOT file with an RNTuple in it?:treemap.zip
(This is a
.zipfile with.rootfile in it because github refuses to accept.rootfiles)