[cling] Replace usage of TextInput with LineEditor

[devajithvs]

This Pull request:

• Replace all occurrences of TextInput with LLVM's LineEditor library in CLING. This moves the codebase closer to clang-repl and might help in future changes. This will help in removing this whole folder from CLING - https://github.com/root-project/cling/tree/master/lib/UserInterface/textinput
• Corresponding replacement should also be made in ROOT for complete removal of TextInput. Not as straightforward as this
• A couple of tests were adjusted to make the tests pass
• Upstreamed LLVM patch adding setHistorySize

Changes or fixes:

Checklist:

• tested changes locally
• updated the docs (if necessary)

This PR fixes #

[github-actions]

Test Results

    22 files      22 suites   3d 23h 28m 48s ⏱️
 3 809 tests  3 809 ✅ 0 💤 0 ❌
76 681 runs  76 681 ✅ 0 💤 0 ❌

Results for commit d0efa98.

♻️ This comment has been updated with latest results.

[vgvassilev]

Pretty nice!

[hahnjo]

We need to decide what to do with CLING_HISTSIZE. If we want to support it, the necessary changes should be upstreamed to LLVM first and then backported to our fork. Note that it would be a first and prevent building against a vanilla LLVM!

[vgvassilev]

We need to decide what to do with CLING_HISTSIZE. If we want to support it, the necessary changes should be upstreamed to LLVM first and then backported to our fork. Note that it would be a first and prevent building against a vanilla LLVM!

This was implemented to be able to set the history to 0 so that we do not get different pointers across gdb runs, iirc.

[devajithvs]

We need to decide what to do with CLING_HISTSIZE. If we want to support it, the necessary changes should be upstreamed to LLVM first and then backported to our fork. Note that it would be a first and prevent building against a vanilla LLVM!

From yesterday's discussion, it seems that this does not align with the idea of using a prebuilt vanilla LLVM. I'm tending towards deprecating CLING_HISTSIZE. The functionality was added here: #11286

Regardless, I think the ability to set a history size would be a nice feature for all the tools using it. So, I will try to upstream this anyways. LineEditor hardcodes history size to 800:

root/interpreter/llvm-project/llvm/lib/LineEditor/LineEditor.cpp

Line 224 in 99a1261

::history(Data->Hist, &HE, H_SETSIZE, 800);

[hahnjo]

We need to decide what to do with CLING_HISTSIZE. If we want to support it, the necessary changes should be upstreamed to LLVM first and then backported to our fork. Note that it would be a first and prevent building against a vanilla LLVM!

This was implemented to be able to set the history to 0 so that we do not get different pointers across gdb runs, iirc.

Disabling the history can probably be implemented differently, maybe that's enough.

[devajithvs]

We need to decide what to do with CLING_HISTSIZE. If we want to support it, the necessary changes should be upstreamed to LLVM first and then backported to our fork. Note that it would be a first and prevent building against a vanilla LLVM!

This was implemented to be able to set the history to 0 so that we do not get different pointers across gdb runs, iirc.

Disabling the history can probably be implemented differently, maybe that's enough.

LineEditor doesn't seem to provide a way to do it though. I've opened a PR here: llvm/llvm-project#110092

[devajithvs]

This is marked draft because standalone cling repository will need textinput directory removed (which can go later but will need a separate commit in the standalone repository)

[hahnjo]

LGTM

[vgvassilev]

Nice improvement!

[hahnjo]

@devajithvs this change is approved, can this go in?

[devajithvs]

Yes, PR is ready (Ruff errors are unrelated to the changes). Will still need to remove TextInput completely from the standalone repository after merging this.