Skip to content

[interpreter] Always build LLVM with C++17 #17735

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 23, 2025
Merged

[interpreter] Always build LLVM with C++17 #17735

merged 2 commits into from
Mar 23, 2025

Conversation

@hahnjo
Copy link
Member

@hahnjo hahnjo commented Feb 17, 2025

Closes #17686

@hahnjo hahnjo added in:Build System in:Cling clean build Ask CI to do non-incremental build on PR labels Feb 17, 2025
@hahnjo hahnjo self-assigned this Feb 17, 2025
@hahnjo hahnjo mentioned this pull request Feb 17, 2025
Closed
1 task
@github-actions
Copy link

github-actions bot commented Feb 17, 2025 •
edited
Loading

Test Results

    20 files      20 suites   4d 23h 22m 52s ⏱️
 2 726 tests  2 725 ✅ 0 💤 1 ❌
52 683 runs  52 682 ✅ 0 💤 1 ❌

For more details on these failures, see this check.

Results for commit a3a9d49.

♻️ This comment has been updated with latest results.

@hahnjo
Copy link
Member Author

hahnjo commented Mar 10, 2025

Do we want this for 6.36? llvm/llvm-project#127459 was merged upstream (+ backported to LLVM 20), but I can also create a tag for our LLVM 18, let me know.

@dpiparo
Copy link
Member

dpiparo commented Mar 13, 2025

Yes, thanks: It would be useful to have this for 6.36.

@hahnjo hahnjo marked this pull request as ready for review March 13, 2025 09:47
@hahnjo hahnjo requested a review from bellenot as a code owner March 13, 2025 09:47
@hahnjo
Copy link
Member Author

hahnjo commented Mar 19, 2025

ping @dpiparo @vgvassilev

hahnjo and others added 2 commits March 22, 2025 16:32
@hahnjo
[llvm-project][Support] Ensure complete type DelimitedScope
4797f15 
JSONScopedPrinter has a std::unique_ptr<DelimitedScope> member and
defaulted constructor argument, so it needs a complete type. This
resolves one of the many build errors with C++23 using Clang.

Backport of llvm/llvm-project#127459
@hahnjo
[interpreter] Always build LLVM with C++17
a3a9d49 
Closes root-project#17686
@hahnjo hahnjo merged commit 9d3084b into root-project:master Mar 23, 2025
40 of 67 checks passed
@hahnjo hahnjo deleted the llvm-cxx23 branch March 23, 2025 12:11
@ferdymercury ferdymercury mentioned this pull request Jun 2, 2025
Closed
1 task
@smuzaffar smuzaffar mentioned this pull request Jun 4, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dpiparo dpiparo dpiparo approved these changes

@vgvassilev vgvassilev Awaiting requested review from vgvassilev vgvassilev is a code owner

@devajithvs devajithvs Awaiting requested review from devajithvs

@bellenot bellenot Awaiting requested review from bellenot bellenot is a code owner

Assignees

@hahnjo hahnjo

Labels

clean build Ask CI to do non-incremental build on PR in:Build System in:Cling

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

C++23 crash in DiagnosticInfo.h

2 participants

@hahnjo @dpiparo