[tmva][sofie] Fix compilation warnings due to missing override#18030
Merged
lmoneta merged 1 commit intoroot-project:masterfrom Mar 19, 2025
Merged
[tmva][sofie] Fix compilation warnings due to missing override#18030lmoneta merged 1 commit intoroot-project:masterfrom
lmoneta merged 1 commit intoroot-project:masterfrom
Conversation
Test Results 20 files 20 suites 5d 13h 10m 31s ⏱️ Results for commit 512217b. ♻️ This comment has been updated with latest results. |
sanjibansg
approved these changes
Mar 18, 2025
Collaborator
sanjibansg
left a comment
sanjibansg
left a comment
There was a problem hiding this comment.
LGTM!
Thanks for the change, just some minor suggestions on removing commented code.
- remove also some warning happening by variable re-declaration when not using Session in generated code - fix issue in operator Range when using verbose mode
lmoneta
force-pushed
the
tmva_fix_warnings
branch
from
b273f0e to
512217b
Compare
sanjibansg
approved these changes
Mar 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.