[CMake] Revert to LLVM_LIBRARY_DIR in clingutils for builtin_clang=OFF #18407
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Following up one 02b0dc1, using again `LLVM_LIBRARY_DIR` instead of `LLVM_DIR` in case of `builtin_clang=OFF` and when `CLANG_INSTALL_PREFIX` was not set by the users. The `LLVM_DIR` variable is only a user hint to `find_package(LLVM)`.
Test Results 18 files 18 suites 3d 23h 20m 18s ⏱️ For more details on these failures, see this check. Results for commit e8f44af. |
Merged
Contributor
Author
|
Superseded by #18460. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following up one 02b0dc1, using again
LLVM_LIBRARY_DIRinstead ofLLVM_DIRin case ofbuiltin_clang=OFFand whenCLANG_INSTALL_PREFIXwas not set by the users. TheLLVM_DIRvariable is only a user hint tofind_package(LLVM).See also the discussion in #18386 (comment).