[cppyy] fix iadd pythonization for np/array buffers#18999
Merged
dpiparo merged 2 commits intoroot-project:masterfrom Jun 21, 2025
Merged
[cppyy] fix iadd pythonization for np/array buffers#18999dpiparo merged 2 commits intoroot-project:masterfrom
dpiparo merged 2 commits intoroot-project:masterfrom
Conversation
Test Results 20 files 20 suites 3d 16h 35m 20s ⏱️ For more details on these failures, see this check. Results for commit d81e2c3. ♻️ This comment has been updated with latest results. |
Member
|
Thanks for these changes. Can we add a (some) test(s)? |
fe6a7aa to
2a01ccc
Compare
510148c to
725b8cb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of wlav/CPyCppyy#51
Fixes #18768
Currently, the
iaddimplementation forstd::vectorinPythonize.cxxworks perfectly with Python lists and iterables for which we have anItemGetter. But the code path for numpy/array buffers do not. The difference betweenx+=yandx.__iadd__(y)leads to unintuitive behaviour: if the intent is to obtain the resulting iterator when calling insert, the user can dod.insert(d.end(), a)which makes more sense than expecting it fromd+=a. When the user does calld+=a, since__iadd__is overriden, operation does not end with the call toVectorIAddwhich should just return the iterator, and reflect the change by insertion ond. Instead, it ends withd = d.__iadd__(a)which reassignsdto the returned iterator, losing the vector in the process. This PR fixes this by returning self in our pythonization.