[jupyter] Add option in .rootrc to disable jsroot by default when opening notebooks #19078
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
siliataider
requested review from
linev
and removed request for
dpiparo and
vepadulano
linev
requested changes
Jun 18, 2025
Member
linev
left a comment
linev
left a comment
There was a problem hiding this comment.
Very nice.
But please change variable name
siliataider
force-pushed
the
jsroot
branch
2 times, most recently
from
2a11777 to
689e741
Compare
Test Results 19 files 19 suites 3d 13h 12m 54s ⏱️ For more details on these failures, see this check. Results for commit d6ef1d7. ♻️ This comment has been updated with latest results. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pull request:
Changes or fixes:
JSROOT is on by default when opening a new notebook, users may want to disable it for their sessions without having to add one line per notebook, but instead one line in .rootrc that applies for all.
This PR adds the functionality to disable JSROOT in Jupyter notebooks by default through a new .rootrc parameter
JSROOT.Disable.Checklist:
This PR fixes #19068