roottest: avoid generated unneeded pcm files#19324
Merged
pcanal merged 4 commits intoroot-project:masterfrom Jul 29, 2025
Merged
roottest: avoid generated unneeded pcm files#19324pcanal merged 4 commits intoroot-project:masterfrom
pcanal merged 4 commits intoroot-project:masterfrom
Conversation
Test Results 21 files 21 suites 3d 8h 55m 17s ⏱️ Results for commit 58d7587. ♻️ This comment has been updated with latest results. |
The tests are checking if the dictionary source files can compile. Having the pcm files around can affect the other tests in the same directory, for example in case those other test runs before the pcm has been rebuild (and it depend on something that has already been rebuild).
Member
Author
|
@dpiparo @vepadulano This is now ready for review. It works well but requires a clean build (to get rid of the the stale-no-longer produced pcm files). |
vepadulano
requested changes
Jul 23, 2025
Member
vepadulano
left a comment
vepadulano
left a comment
There was a problem hiding this comment.
Mostly good, but I believe we should address the CI workflow issue separately
Member
Author
Yes, it actually was. |
Member
Ok, does it mean that the third commit of this PR can be removed? |
pcanal
force-pushed
the
roottest-no-pcm
branch
2 times, most recently
from
cb8fc47 to
b60aac6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The tests are checking if the dictionary source files can compile.
Having the pcm files around can affect the other tests in the same directory, for example in case those
other test runs before the pcm has been rebuild (and it depend on something that has already been rebuild).