[build] Simplify CMake in ATLAS DataVector test directory#19344
[build] Simplify CMake in ATLAS DataVector test directory#19344vepadulano merged 2 commits intoroot-project:masterfrom
Conversation
Test Results 23 files 23 suites 3d 22h 13m 22s ⏱️ Results for commit 2b80641. ♻️ This comment has been updated with latest results. |
dpiparo
left a comment
There was a problem hiding this comment.
thanks for these changes. I am approving the PR, with the caveat that the debian failure perhaps deserves a closer look before merging.
|
Indeed the failure https://github.com/root-project/root/actions/runs/16219472129/job/45796305238?pr=19344#step:11:12437 is worrying It's unclear to me whether it happens because of the changes in this PR. |
The failure on alma9-clang looks real
Using the `NO_CXXMODULE` option of `ROOTTEST_GENERATE_DICTIONARY` produces dictionary artifacts that correctly reproduce the ATLAS environment (i.e. there are no C++ module neither modulemap produced in the test build directory).
a975161 to
2b80641
Compare
|
The problem was understood, there was a missing |
|
Thanks |
Using the
NO_CXXMODULEoption ofROOTTEST_GENERATE_DICTIONARYproduces dictionary artifacts that correctly reproduce the ATLAS environment (i.e. there are no C++ module neither modulemap produced in the test build directory).