[DF] Allow snapshotting from TTree to RNTuple#19364
Merged
enirolf merged 3 commits intoroot-project:masterfrom Jul 23, 2025
Merged
[DF] Allow snapshotting from TTree to RNTuple#19364enirolf merged 3 commits intoroot-project:masterfrom
enirolf merged 3 commits intoroot-project:masterfrom
Conversation
enirolf
requested review from
hahnjo,
jblomer,
pcanal,
silverweed and
vepadulano
enirolf
force-pushed
the
rdf-snap-ttree-to-rntuple
branch
from
46413f9 to
26dc6f0
Compare
Test Results 21 files 21 suites 3d 9h 36m 55s ⏱️ For more details on these failures, see this check. Results for commit 3e1ab31. ♻️ This comment has been updated with latest results. |
hahnjo
reviewed
Jul 15, 2025
Member
hahnjo
left a comment
hahnjo
left a comment
There was a problem hiding this comment.
Great! LG from an RNTuple perspective, I let RDataFrame experts comment if there's anything else to test in particular (but I think you already discussed offline)
enirolf
force-pushed
the
rdf-snap-ttree-to-rntuple
branch
from
26dc6f0 to
70e54ce
Compare
jblomer
reviewed
Jul 15, 2025
Contributor
jblomer
left a comment
jblomer
left a comment
There was a problem hiding this comment.
Great! RDF owners should give final approval.
pcanal
reviewed
Jul 16, 2025
Templated snapshotting has been removed, so the "*Templated" and "*JITted" tests have become identical.
enirolf
force-pushed
the
rdf-snap-ttree-to-rntuple
branch
from
70e54ce to
d46cd89
Compare
vepadulano
requested changes
Jul 18, 2025
Member
vepadulano
left a comment
vepadulano
left a comment
There was a problem hiding this comment.
Changes are great! just a small warning to fix
enirolf
force-pushed
the
rdf-snap-ttree-to-rntuple
branch
4 times, most recently
from
4e04e96 to
0aa713f
Compare
enirolf
force-pushed
the
rdf-snap-ttree-to-rntuple
branch
from
0aa713f to
1a93455
Compare
Also check the resulting on-disk layout, as well as the effects of turning the `kVectorToRVec` snapshot option off.
enirolf
force-pushed
the
rdf-snap-ttree-to-rntuple
branch
from
1a93455 to
3e1ab31
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Snapshotting from TTree to RNTuple was initially disabled, because it was assumed that this would require adopting (parts of) the machinery of the RNTupleImporter to make it work. However, this is all already taken care of by the TTree's datasource.
One caveat is the support of leaflist branches. It is not possible to snapshot these fully, and users always need to explicitly pass their leaf names to
Snapshot. This, however, is something fundamentally unsupported by the RDataFrame. The reason is that for snapshotting to TTree, it is impossible/overly complex to correctly set the branch addresses in the output TTree for these branches at runtime, without JITting. For RNTuple, however, this is likely more doable by using untyped record fields (similar to how it is done in the importer). This requires some more investigation, however, and if indeed possible will be addressed in a follow-up PR.