[Python][RDF] Enable Support for C++ Free Functions in RDF Define and Filter#19437
Merged
siliataider merged 5 commits intoroot-project:masterfrom Jul 31, 2025
Merged
[Python][RDF] Enable Support for C++ Free Functions in RDF Define and Filter#19437siliataider merged 5 commits intoroot-project:masterfrom
siliataider merged 5 commits intoroot-project:masterfrom
Conversation
Test Results 20 files 20 suites 3d 0h 3m 40s ⏱️ For more details on these failures, see this check. Results for commit e1c1f4c. ♻️ This comment has been updated with latest results. |
74aa29e to
91b5612
Compare
vepadulano
requested changes
Jul 28, 2025
Member
vepadulano
left a comment
There was a problem hiding this comment.
Thank you, this is great! I left a couple of minor remarks
bindings/pyroot/pythonizations/python/ROOT/_pythonization/_rdf_pyz.py
Outdated
Show resolved
Hide resolved
436854f to
ad8ea5e
Compare
vepadulano
approved these changes
Jul 30, 2025
Member
vepadulano
left a comment
There was a problem hiding this comment.
LGTM, very nicely done! I just left a comment to check commit consistency
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This Pull request:
This PR extends the
RDataFramepythonizations by adding support for passing C++ free functions to.Define()andFilteroperations, with support for:The implementation works by converting the free function to
std::functionusing the function's signature.Warning
This currently doesn't work if the function takes templated types as input arguments like STL containers (e.g.
std::vector<T>) because of #19358Concretely, this doesn't work:
Important
Prerequisites / TODO:
- This should not block this PR though
Quick demo: