[Python] Restructure Python libraries to not require system links#19465
Merged
guitargeek merged 1 commit intoroot-project:masterfrom Jul 31, 2025
Merged
[Python] Restructure Python libraries to not require system links#19465guitargeek merged 1 commit intoroot-project:masterfrom
guitargeek merged 1 commit intoroot-project:masterfrom
Conversation
guitargeek
added
improvement
in:Python Interface
clean build
guitargeek
force-pushed
the
python_no_symlink
branch
from
fe66d3f to
0c52207
Compare
Test Results 21 files 21 suites 3d 8h 32m 9s ⏱️ For more details on these failures, see this check. Results for commit e4beb3c. ♻️ This comment has been updated with latest results. |
guitargeek
force-pushed
the
python_no_symlink
branch
5 times, most recently
from
50264a7 to
7759383
Compare
guitargeek
requested review from
bellenot,
dpiparo and
vepadulano
as code owners
guitargeek
force-pushed
the
python_no_symlink
branch
3 times, most recently
from
893ef46 to
cc5edf2
Compare
Split the `libcppyy.so` shared library into two libraries: one library with the C++ API that will be installed into `CMAKE_INSTALL_LIBRARYDIR`, and a CPython extension that will be installed to `CMAKE_INSTALL_PYTHONDIR`. Note that the C++ API is also used by other ROOT libraries (TPython). Like this, we don't have to use symlinks to ensure that the libraries are found in both directories.
guitargeek
force-pushed
the
python_no_symlink
branch
from
cc5edf2 to
e4beb3c
Compare
vepadulano
approved these changes
Jul 31, 2025
Member
vepadulano
left a comment
vepadulano
left a comment
There was a problem hiding this comment.
LGTM! And in #19456 I checked that this works with the Python wheel workflow as well 🎉
Member
|
btw "symlink" stands for "symbolic link", not "system" 😉 |
Contributor
Author
|
Sorry! Fortunately I can't repeat this mistake because there are no |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Restructure Python libraries to not require system links.