[roottest] use cmake for all root/tree tests by linev · Pull Request #19516 · root-project/root

linev · 2025-08-04T11:05:12Z

No description provided.

Delete unused tree.h and tree.C macros, were copied from root/io/treeproblem

Extra rule to copy rootlogin.C script Remove unused mixing.ref file

Was not used in Makefile

Reactivate runabstract.cxx test

Need extra work to use selectors and files from source directory

Avoid extra configuring of include path

Two tests failing while eventdata.root file is missing on eos

@ttree

Getting linker failure when trying to compile hardTreeReaderTest.cpp macro. ``` hardTreeReaderTest_cpp_ACLiC_dict.obj : error LNK2019: unresolved external symbol "public: static class TClass * __cdecl B::Class(void)" (?Class@B@@SAPEAVTClass@@xz) referenced in function "public: class TBranch * __cdecl TTree::Branch<class B>(char const *,class B * *,int,int)" (??$Branch@VB@@@ttree@@QEAAPEAVTBranch@@PEBDPEAPEAVB@@hh@Z) [C:\ROOT-CI\build\roottest\root\tree\reader\roottest-root-tree-reader-hardTreeReaderTest-compile-macro.vcxproj] hardTreeReaderTest_cpp_ACLiC_dict.obj : error LNK2001: unresolved external symbol "public: virtual void __cdecl B::Streamer(class TBuffer &)" (?Streamer@B@@UEAAXAEAVTBuffer@@@z) [C:\ROOT-CI\build\roottest\root\tree\reader\roottest-root-tree-reader-hardTreeReaderTest-compile-macro.vcxproj] hardTreeReaderTest_cpp_ACLiC_dict.obj : error LNK2019: unresolved external symbol "public: static class TClass * __cdecl A::Class(void)" (?Class@A@@SAPEAVTClass@@xz) referenced in function "public: virtual class TClass * __cdecl A::IsA(void)const " (?IsA@A@@UEBAPEAVTClass@@xz) [C:\ROOT-CI\build\roottest\root\tree\reader\roottest-root-tree-reader-hardTreeReaderTest-compile-macro.vcxproj] hardTreeReaderTest_cpp_ACLiC_dict.obj : error LNK2001: unresolved external symbol "public: virtual void __cdecl A::Streamer(class TBuffer &)" (?Streamer@A@@UEAAXAEAVTBuffer@@@z) [C:\ROOT-CI\build\roottest\root\tree\reader\roottest-root-tree-reader-hardTreeReaderTest-compile-macro.vcxproj] C:\ROOT-CI\build\roottest\root\tree\reader\hardTreeReaderTest_cpp.dll : fatal error LNK1120: 4 unresolved externals [C:\ROOT-CI\build\roottest\root\tree\reader\roottest-root-tree-reader-hardTreeReaderTest-compile-macro.vcxproj] ```

Was not used before Run provided methods Use compression 0 to avoid difference on different platforms

Add ref file, set fixed seed for gRandom

Instead DEPENDS and PRE_CMD use separate tests and fixtures to configure test dependencies

For reflex part create normal dictionary with library Load necessary reflex or cint library via ROOTEXE_OPTS, otherwise provided classes not available in named macros

Seems to be on Windows 32bit test works exactly the same

If fails while branch.root file left open. It works correctly on other platforms

Remove printout with pointer to allow tests on Windows, otherwise `grep -v 0x` has to be involved which excludes Windows usage

Avoid duplication of dictionary when compile these macros on Windows

Build dictionary in convertIssues/ subdir and correspondent lib before running test Remove exe bit from many sources Remove rootlogon.C script - used only with runiobug.C, where necessary script load with ROOTEXE_OPTS

Typical is compilation problem with dictionaries Or use or utils.cc

Replace <Riostream.h> by <iostream> Replace <stdio.h> by <cstdio>

ABC used in some Windows headers as type and conflict with ABC type name used in the original test

On Mac platform may produce compiler warnings

pcanal · 2025-08-04T17:40:24Z

Is there a way to split the PR by group of 2 or 3 directories?

github-actions · 2025-08-04T18:07:01Z

Test Results

21 files 21 suites 3d 7h 2m 38s ⏱️
3 389 tests 3 389 ✅ 0 💤 0 ❌
69 410 runs 69 410 ✅ 0 💤 0 ❌

Results for commit 7a64410.

linev · 2025-08-04T19:09:13Z

Is there a way to split the PR by group of 2 or 3 directories?

Yes, it is possible.
Each commit normally changes one sub-directory.
Plus I add extra commits when need to fix/prevent problem on Windows.

There are 33 commits. How much PRs you are want?

pcanal · 2025-08-04T19:17:03Z

You leave it as is or you can split. The difference is that it takes a bit to review each directories and the more there is the harder it is to keep track of which one I have reviewed.

linev · 2025-08-04T19:34:11Z

@pcanal
I create 6 separate PRs.
Let see if they will go through CI

linev · 2025-08-05T06:06:54Z

This big PR splitted on #19522, #19523, #19524, #19525, #19526, #19527

linev added 13 commits August 1, 2025 10:02

[roottest] use cmake for tree/treeproblem

8dd9732

Delete unused tree.h and tree.C macros, were copied from root/io/treeproblem

[roottest] use cmake for root/tree/string tests

7a73bdc

[roottest] use cmake for root/tree/stl tests

2e3b115

Extra rule to copy rootlogin.C script Remove unused mixing.ref file

[roottest] activate runsimple.C in root/tree/stl dir

3a8641d

Was not used in Makefile

[roottest] use cmake for root/tree/split tests

d37aff7

Reactivate runabstract.cxx test

[roottest] use cmake for root/tree/selectorreader

313aab8

Need extra work to use selectors and files from source directory

[roottest] simplify selectors usage in root/tree/selectorreader tests

504d4f3

Avoid extra configuring of include path

[roottest] use cmake for root/tree/selector tests

05ba2ab

[roottest] use cmake for root/tree/readfile

379850b

[roottest] use cmake for root/tree/reader tests

6800e88

Two tests failing while eventdata.root file is missing on eos

[roottest] add missing root/tree/readcin tests to cmake

fb7cad4

[roottest] use cmake for root/tree/query

c5305bb

linev requested a review from pcanal August 4, 2025 11:05

linev self-assigned this Aug 4, 2025

linev requested a review from bellenot as a code owner August 4, 2025 11:05

linev added the in:Testing label Aug 4, 2025

linev requested a review from dpiparo as a code owner August 4, 2025 11:05

linev added the in:TTree label Aug 4, 2025

This was referenced Aug 4, 2025

[roottest] use cmake for root/tree tests #19492

Closed

[roottest] root/tree/branches/runseparate.C fails on Windows #19520

Open

linev added 9 commits August 4, 2025 16:28

[rootest] activate in cmake root/tree/pointers

8b63594

Was not used before Run provided methods Use compression 0 to avoid difference on different platforms

[roottest] use cmake for root/tree/leaves tests

735a925

[roottest] use cmake for root/tree/interpreted test

b7448c8

Add ref file, set fixed seed for gRandom

[roottest] use cmake for root/tree/index tests

1508a0e

[roottest] use fixtures for root/tree/fastcloning tests

b9f28dc

Instead DEPENDS and PRE_CMD use separate tests and fixtures to configure test dependencies

[roottest] use cmake for tree/evolution/split tests

278754a

[roottest] support cc and cpp extension for MACRO

92310dd

[roottest] use cmake for root/tree/evolution tests

1220131

[roottest] remove unsed files from root/tree/cloning dir

45e55f1

linev added 11 commits August 4, 2025 16:28

[roottest] use cmake for root/tree/chain

7ea8152

[roottest] use cmake for root/tree/branches tests

0366e77

For reflex part create normal dictionary with library Load necessary reflex or cint library via ROOTEXE_OPTS, otherwise provided classes not available in named macros

[roottest] remove execGetBranch.ref32 file

a77b11a

Seems to be on Windows 32bit test works exactly the same

[roottest] disable root-tree-branches-separate test on windows

0bd2c0e

If fails while branch.root file left open. It works correctly on other platforms

[roottest] use cmake for root/tree/array tests

e362f9b

Remove printout with pointer to allow tests on Windows, otherwise `grep -v 0x` has to be involved which excludes Windows usage

[roottest] combine together save.C and TestObj.cpp macros

7907fc0

Avoid duplication of dictionary when compile these macros on Windows

[roottest] use cmake for root/tree/address tests

2e0ace3

Build dictionary in convertIssues/ subdir and correspondent lib before running test Remove exe bit from many sources Remove rootlogon.C script - used only with runiobug.C, where necessary script load with ROOTEXE_OPTS

[roottest] disable several root/tree/addresses test on Windows

fd48fb1

Typical is compilation problem with dictionaries Or use or utils.cc

[roottest] use C++ includes in root/tree tests

ecec743

Replace <Riostream.h> by <iostream> Replace <stdio.h> by <cstdio>

[roottest] rename ABC -> BaseABC in tree/branches tests

298bed2

ABC used in some Windows headers as type and conflict with ABC type name used in the original test

[roottest] compile assert_tread.cxx macro before invoke

7a64410

On Mac platform may produce compiler warnings

linev force-pushed the roottest_tree_part2 branch from 9a5d2d1 to 7a64410 Compare August 4, 2025 15:23

linev closed this Aug 5, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[roottest] use cmake for all root/tree tests#19516

[roottest] use cmake for all root/tree tests#19516
linev wants to merge 33 commits intoroot-project:masterfrom
linev:roottest_tree_part2

linev commented Aug 4, 2025

Uh oh!

pcanal commented Aug 4, 2025

Uh oh!

github-actions bot commented Aug 4, 2025

Uh oh!

linev commented Aug 4, 2025

Uh oh!

pcanal commented Aug 4, 2025

Uh oh!

linev commented Aug 4, 2025

Uh oh!

linev commented Aug 5, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

linev commented Aug 4, 2025

Uh oh!

pcanal commented Aug 4, 2025

Uh oh!

github-actions bot commented Aug 4, 2025

Test Results

Uh oh!

linev commented Aug 4, 2025

Uh oh!

pcanal commented Aug 4, 2025

Uh oh!

linev commented Aug 4, 2025

Uh oh!

linev commented Aug 5, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants