[tmva][sofie] Add support for some new operators:#19521
Merged
lmoneta merged 4 commits intoroot-project:masterfrom Feb 27, 2026
Merged
[tmva][sofie] Add support for some new operators:#19521lmoneta merged 4 commits intoroot-project:masterfrom
lmoneta merged 4 commits intoroot-project:masterfrom
Conversation
Test Results 22 files 22 suites 3d 7h 4m 4s ⏱️ For more details on these failures, see this check. Results for commit 0664415. ♻️ This comment has been updated with latest results. |
lmoneta
force-pushed
the
tmva_sofie_new_operator_devs
branch
from
8817a96 to
2b9ba84
Compare
Add Mod as a new BasicBinary operators. Have a different parsing function to distinguish the integfer case (mod) or the floating case (fmod) when the attribute is set
Add support for LogSoftMax operator. Re-use the iperator definition of SOftMax, just adding a flag to distinguish the log case.
lmoneta
force-pushed
the
tmva_sofie_new_operator_devs
branch
5 times, most recently
from
ea9959a to
a8760e6
Compare
…oleans Correct handle booleans types when parsing from ONNX Fix also in Keras parser Softmax that ROPerator_Softmax is not a template class anymore and supporting LogSoftMax
lmoneta
force-pushed
the
tmva_sofie_new_operator_devs
branch
from
a8760e6 to
0664415
Compare
sanjibansg
approved these changes
Feb 27, 2026
Collaborator
sanjibansg
left a comment
sanjibansg
left a comment
There was a problem hiding this comment.
LGTM!
Thanks for these new features. The failing CI tests seems unrelated.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This Pull request adds support for these new operators: