[roottest] use cmake for root/treedraw test#19534
Merged
linev merged 3 commits intoroot-project:masterfrom Aug 5, 2025
Merged
Conversation
Use hsimple.C from tutorials directory Adjust hsimple.ps.ref file to used hsimple Remove rootlogon.C script and compile utils.cc macro directly Disable on Windows while utils.cc does not compiled there
Allows to use this script on Windows Extra redirection of debug output is not really necessary Use c++ includes
Now utils.cc can be compiled on Windows as well
Test Results 21 files 21 suites 3d 11h 53m 19s ⏱️ For more details on these failures, see this check. Results for commit 581d741. |
bellenot
reviewed
Aug 5, 2025
Member
bellenot
left a comment
bellenot
left a comment
There was a problem hiding this comment.
LGTM but this test is failing: gtest-tree-dataframe-datasource-root
Member
Author
This failure is not related to PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use hsimple.C from tutorials directory
Adjust hsimple.ps.ref file to used hsimple
Remove rootlogon.C script and compile utils.cc macro directly
Adjust utils.cc to be able use it on Windows