Add extra code to specify workflow conditions#19566
Merged
vepadulano merged 2 commits intoroot-project:masterfrom Aug 8, 2025
Merged
Add extra code to specify workflow conditions#19566vepadulano merged 2 commits intoroot-project:masterfrom
vepadulano merged 2 commits intoroot-project:masterfrom
Conversation
Even though it is redundant with the `on` section, it looks like this is the way to have the workflow properly run.
vepadulano
added
in:Build System
build-python-wheels
Member
Author
|
Something broke the workflow in the meantime :) investigating... |
vepadulano
added
build-python-wheels
Member
|
You probably want to skip the upload step for PR builds. It currently doesn't have access to the secret, and even if it had I'm not sure it should actually upload something to the "production" repository... |
Test Results 21 files 21 suites 3d 8h 58m 4s ⏱️ Results for commit ac36d70. |
Member
Author
Thank you! I was thinking the same, will do it in a followup PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed the workflow is being skipped (e.g. https://github.com/root-project/root/actions/runs/16792883609). The gh UI doesn't say why. I have a suspicion that it is yet another undocumented behaviour. This commit suggests to add extra code to specify each and every scenario where the workflow can run.
Even though it is redundant with the
onsection, it looks like this is the way to have the workflow properly run.