[roottest] enable several `root/aclic` tests by linev · Pull Request #19569 · root-project/root

linev · 2025-08-07T12:40:26Z

Implement new version of aclic/nolinkdep tests. Seems to be they were testsed before with CINT and were not working with cling. Now at least basic tests are works. ~~Plus linking between script2.C and single.C~~. Also renaming of script2.C into script.C is testing
Enable again aclic/offset test, was completely skipped
Remove many .rootrc file which are now not necessary

bellenot

Again, I'm not familiar enough with these tests. Let's ask @pcanal what he thinks about this PR

github-actions · 2025-08-07T23:06:24Z

Test Results

18 files 18 suites 3d 3h 18m 49s ⏱️
3 668 tests 3 624 ✅ 0 💤 44 ❌
64 436 runs 64 146 ✅ 246 💤 44 ❌

For more details on these failures, see this check.

Results for commit 68da512.

♻️ This comment has been updated with latest results.

roottest/root/aclic/nolinkdep/CMakeLists.txt

pcanal · 2025-08-28T21:18:15Z

roottest/root/aclic/nolinkdep/CMakeLists.txt

+                  FIXTURES_SETUP root-aclic-nolinkdep-load1-fixture)
+
+ROOTTEST_ADD_TEST(load2
+                  MACRO script2.C+


I am unclear whether the intent was to run this script with or without script1_C being there ... but did need to have single_C present (as opposed to the running of script1).

pcanal · 2025-08-28T21:19:41Z

roottest/root/aclic/nolinkdep/CMakeLists.txt

+                  FIXTURES_SETUP root-aclic-nolinkdep-single-fixture)
+
+ROOTTEST_ADD_TEST(load1
+                  MACRO script1.C+


The corresponding makefile like was:

load1b.log: load1.log load2b.log $(CMDECHO) rm -f single_C.$(DllSuf); root.exe -b -l -q script1.C+ > load1b.log 2>&1

i.e. this step was meant to be run without single_C being present.

Seems to be logic in "nolingdep" more complicated.
There is rootlogon.C script which changes linker flags.
So one should not try to link libraries with each other but check if changed linker flags allow to run such compiled macros without having some symbols defined.
I will adjust cmake once again

There is rootlogon.C script which changes linker flags.

I missed/forgot about that. So actually the whole point of the test is to make sure that ACLiC is following the request of those flags (they are all meant to force ACliC to only keep the library actually used independently of how ROOT was compiled.

So one should not try to link libraries with each other but

In the contrary it is the whole point, i.e. to link the libraries with each other and check/make-sure that the 'useless' ones have been dropped.

without having some symbols defined.

This is not the goal. Rather testing 'allow missing symbols", this test is checking dead_strip_dylibs and -Wl,--as-needed which is about ignoring libraries that do not actually provide symbols.

In current version I fully replicate logic in GNUMakefile.
So I did not try extra compile macro before calling link.C script.
And then remove in-between single_C.so - as it was done in GNUMakefile.

Question - should we add ROOTTEST_COMPILE_MACRO before?

Question - should we add ROOTTEST_COMPILE_MACRO before?

We have to and/or re-introduce the link(1) part.

Trying to run original GNUMakefile failing.
It fails with load2.log with following statement:

Processing script2.C+... In file included from script2_C_ACLiC_dict dictionary payload:8: ././script2.C:9:6: error: redefinition of 'script' void script() { ^ ././script1.C:7:6: note: previous definition is here void script() { ^ Warning in <TInterpreter::TCling::RegisterModule>: Problems declaring payload for module script2_C_ACLiC_dict. input_line_16:2:3: error: use of undeclared identifier 'script2' (script2()) ^ Error in <HandleInterpreterException>: Error evaluating expression (script2()) Execution of your code was aborted.

That's why I change original link.C script - it was not working.

So I propose to remove aclic/nolinkdep test from the PR and one can try to activate it again separately.

roottest/root/aclic/nolinkdep/.rootrc

.rootrc generated automatically if missing

With CLING some old features no longer working, but at least one can compile and run existing scripts And also renaming of scripts works as before

Here macro with incomplete symbols testes, which requires changes in linker flags Try fully reproduce dependency from makefiles - which now can be deleted

Building shared library with missing symbols does not work on windows Probably one can manipulate linker flags via rootlogon.C script - as it done for Linux and Mac

pcanal · 2025-09-09T16:12:15Z

roottest/root/aclic/nolinkdep/CMakeLists.txt

+# building shared library with missing symbols does not work on windows
+# probably one can manipulate linker flags via rootlogon.C script - as it done for Linux and Mac
+if(MSVC AND NOT win_broken_tests)
+  return()
+endif()
+
+ROOTTEST_ADD_TEST(build1
+                  MACRO link.C
+                  PRECMD ${CMAKE_COMMAND} -E remove "script1_C.* script2_C.*"
+                  COPY_TO_BUILDDIR single.C script.C script1.C script2.C rootlogon.C
+                  FIXTURES_SETUP root-aclic-nolinkdep-build1-fixture)
+
+ROOTTEST_ADD_TEST(single
+                  MACRO ${CMAKE_CURRENT_BINARY_DIR}/single.C+
+                  FIXTURES_REQUIRED root-aclic-nolinkdep-build1-fixture
+                  FIXTURES_SETUP root-aclic-nolinkdep-single-fixture)
+
+
+ROOTTEST_ADD_TEST(load1
+                  MACRO ${CMAKE_CURRENT_BINARY_DIR}/script1.C+
+                  FIXTURES_REQUIRED root-aclic-nolinkdep-build1-fixture
+                                    root-aclic-nolinkdep-single-fixture 
+                  FIXTURES_SETUP root-aclic-nolinkdep-load1-fixture)
+
+ROOTTEST_ADD_TEST(load2
+                  MACRO ${CMAKE_CURRENT_BINARY_DIR}/script2.C+
+                  FIXTURES_REQUIRED root-aclic-nolinkdep-build1-fixture
+                                    root-aclic-nolinkdep-single-fixture
+                  FIXTURES_SETUP root-aclic-nolinkdep-load2-fixture)


ROOTTEST_COMPILE_MACRO(single_C
# except that this is not yet support by COMPILE_MACRO
PRECMD ${CMAKE_COMMAND} -E remove "script1_C.* script2_C.*"
FIXTURES_SETUP root-aclic-nolinkdep-build1-single-fixture)

ROOTTEST_COMPILE_MACRO(script1_C
BUILDLIB single_C
FIXTURES_REQUIRED root-aclic-nolinkdep-build1-single-fixture
FIXTURES_SETUP root-aclic-nolinkdep-build1-script1-fixture)

ROOTTEST_COMPILE_MACRO(script2_C
BUILDLIB single_C script1_C
FIXTURES_REQUIRED root-aclic-nolinkdep-build1-single-fixture
FIXTURES_REQUIRED root-aclic-nolinkdep-build1-script1-fixture
FIXTURES_SETUP root-aclic-nolinkdep-build1-script2-fixture)

ROOTTEST_ADD_TEST(single
MACRO ${CMAKE_CURRENT_BINARY_DIR}/single.C+
FIXTURES_REQUIRED root-aclic-nolinkdep-build1-script2-fixture
FIXTURES_SETUP root-aclic-nolinkdep-single-fixture)

linev · 2025-09-10T08:08:37Z

Close in favor of #19857 and #19856

linev self-assigned this Aug 7, 2025

linev requested review from bellenot and dpiparo as code owners August 7, 2025 12:40

linev added affects:master in:Testing labels Aug 7, 2025

bellenot requested a review from pcanal August 7, 2025 13:56

bellenot reviewed Aug 7, 2025

View reviewed changes

linev requested review from bellenot and removed request for dpiparo August 7, 2025 14:27

linev force-pushed the roottest_aclic branch from 01171e0 to 714a6b8 Compare August 7, 2025 14:30

linev force-pushed the roottest_aclic branch from 714a6b8 to 769bb97 Compare August 8, 2025 06:20

linev closed this Aug 22, 2025

linev reopened this Aug 22, 2025

pcanal reviewed Aug 28, 2025

View reviewed changes

roottest/root/aclic/nolinkdep/CMakeLists.txt Outdated Show resolved Hide resolved

pcanal reviewed Aug 28, 2025

View reviewed changes

roottest/root/aclic/nolinkdep/CMakeLists.txt Outdated Show resolved Hide resolved

pcanal reviewed Aug 28, 2025

View reviewed changes

roottest/root/aclic/nolinkdep/.rootrc Show resolved Hide resolved

linev added 5 commits August 29, 2025 08:28

[roottest] remove not required files from aclic tests

0b47a5f

.rootrc generated automatically if missing

[roottest] use fixture in aclic tests, remove unnecessary deps

3246e81

[roottest] provide cmake for root/aclic/nolinkdep

8a31535

With CLING some old features no longer working, but at least one can compile and run existing scripts And also renaming of scripts works as before

[roottest] enable aclic/offset test in cmake

832f53c

[roottest] use rootlogon in aclic/nolinkdep tests

44a3a77

Here macro with incomplete symbols testes, which requires changes in linker flags Try fully reproduce dependency from makefiles - which now can be deleted

linev force-pushed the roottest_aclic branch from 769bb97 to 44a3a77 Compare August 29, 2025 07:33

[roottest] disable aclic/nolinkdep on Windows

68da512

Building shared library with missing symbols does not work on windows Probably one can manipulate linker flags via rootlogon.C script - as it done for Linux and Mac

linev force-pushed the roottest_aclic branch from e5b3a5c to 68da512 Compare August 29, 2025 10:54

linev closed this Sep 5, 2025

linev reopened this Sep 5, 2025

pcanal reviewed Sep 9, 2025

View reviewed changes

linev mentioned this pull request Sep 10, 2025

[roottest] use cmake in root/aclic tests #19857

Merged

linev closed this Sep 10, 2025

linev deleted the roottest_aclic branch September 11, 2025 05:58

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[roottest] enable several `root/aclic` tests#19569

[roottest] enable several `root/aclic` tests#19569
linev wants to merge 6 commits intoroot-project:masterfrom
linev:roottest_aclic

linev commented Aug 7, 2025 •

edited

Loading

Uh oh!

bellenot left a comment

Uh oh!

github-actions bot commented Aug 7, 2025 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

pcanal Aug 28, 2025 •

edited

Loading

Uh oh!

pcanal Aug 28, 2025

Uh oh!

linev Aug 29, 2025

Uh oh!

pcanal Aug 29, 2025

Uh oh!

linev Sep 1, 2025

Uh oh!

pcanal Sep 9, 2025

Uh oh!

linev Sep 10, 2025

Uh oh!

Uh oh!

pcanal Sep 9, 2025

Uh oh!

linev commented Sep 10, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

linev commented Aug 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bellenot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Aug 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Test Results

Uh oh!

Uh oh!

Uh oh!

pcanal Aug 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

pcanal Aug 28, 2025

Choose a reason for hiding this comment

Uh oh!

linev Aug 29, 2025

Choose a reason for hiding this comment

Uh oh!

pcanal Aug 29, 2025

Choose a reason for hiding this comment

Uh oh!

linev Sep 1, 2025

Choose a reason for hiding this comment

Uh oh!

pcanal Sep 9, 2025

Choose a reason for hiding this comment

Uh oh!

linev Sep 10, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

pcanal Sep 9, 2025

Choose a reason for hiding this comment

Uh oh!

linev commented Sep 10, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

linev commented Aug 7, 2025 •

edited

Loading

github-actions bot commented Aug 7, 2025 •

edited

Loading

pcanal Aug 28, 2025 •

edited

Loading