Skip to content

[roottest] improve cmake for root/collection#19571

Merged
linev merged 1 commit intoroot-project:masterfrom
linev:roottest_collection
Aug 20, 2025
Merged

[roottest] improve cmake for root/collection#19571
linev merged 1 commit intoroot-project:masterfrom
linev:roottest_collection

Conversation

@linev
Copy link
Member

@linev linev commented Aug 7, 2025

Use explicit list of tests - one test was not present in automatic list
Copy ROOT file only for specific test
Remove unnecessary .rootrc

Use explicit list of test - one test was not present in automatic list
Copy ROOT file only for specific test
@linev linev self-assigned this Aug 7, 2025
@linev linev requested review from bellenot and dpiparo as code owners August 7, 2025 13:00
@linev linev removed the request for review from dpiparo August 7, 2025 13:02
@bellenot bellenot requested a review from pcanal August 7, 2025 13:57
Copy link
Member

@bellenot bellenot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not familiar enough with these tests. Let's ask @pcanal what he thinks about this PR

@linev
Copy link
Member Author

linev commented Aug 7, 2025

I do not change tests - just adding fixtures to have clear order of tests invocation.
DEPENDS argument of ROOTTEST_ADD_TEST does not invoke required test

@github-actions
Copy link

github-actions bot commented Aug 7, 2025

Test Results

    21 files      21 suites   3d 12h 37m 31s ⏱️
 3 251 tests  3 247 ✅ 0 💤 4 ❌
66 549 runs  66 545 ✅ 0 💤 4 ❌

For more details on these failures, see this check.

Results for commit 8302d18.

Copy link
Member

@pcanal pcanal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@linev linev merged commit 21f51e1 into root-project:master Aug 20, 2025
27 of 30 checks passed
@linev linev deleted the roottest_collection branch August 20, 2025 06:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants